Skip to main content

Java and lsof

Update: I found that using Runtime.exec was a bad idea because if you have a 2GB VM footprint then the forked process would require 2G free memory in order to run the lsof command.  We had earlier writte a simple python http rpc server that would allow us to execute native commands(like creating a hardlink or running gunzip) from Java and I changed this code to delagate to RPC call few days back.
So the new code looks like



 public void writeTopCommandOutput(Writer writer) throws IOException {
  String rpcRes = Util.doCommandRpc(rpcUrl, "", ListUtil.create("top", "-n", "2", "-b", "-d", "0.2"));
  writer.write(rpcRes);
 }

 public void writeLsofOutput(Writer writer) throws IOException {
  String pid = getJvmProcessid();
  if (pid != null) {
   pid = pid.trim();
   String rpcRes = Util.doCommandRpc(rpcUrl, "", ListUtil.create("lsof", "-p", pid));
   writer.write(rpcRes);
  }
 }


 --------------------------------------
I was chasing a customer issue and some threads in threaddump showed that they are stuck doing filer I/O. Now I needed to chase what file paths these threads are accessing as few days ago this customer had expereinced same issue. So I asked operations to give me lsof output and as we are a distribured team and engineers dont have access to production machines.It always takes time to chase people and to a programmer this means lots of context switches and it derails your thought process.  My goal is to eliminate as many hoops in my debugging path so I wrote a JSP to get me lsof output from java. This will be a jsp accessible through internal ips only, hurray from next release onwards one more reason to avoid Operations team in chasing issues.
Here is the method I added in jsp


    public void writeLsofOutput(Writer writer) throws IOException {
        String pid = getJvmProcessid();
        if(pid!=null){
            pid = pid.trim();
            String cmdLsof = "lsof -p " + pid;
            executeCmd(writer, cmdLsof);            
        }
    }

    private void executeCmd(Writer writer, String cmd) throws IOException {
        String output;
        Process child = Runtime.getRuntime().exec(cmd, new String []{});            
        BufferedReader stdInput = new BufferedReader(new InputStreamReader(child.getInputStream()));
        while ((output = stdInput.readLine()) != null) {
            writer.write(output + "\n");
            writer.flush();
        }
        stdInput.close();
    }
    public String getJvmProcessid() throws IOException {
        String pid = null;
        File pidFile = new File(System.getenv("CATALINA_PID"));
        if(pidFile.exists()) {
            FileInputStream fin = new FileInputStream(pidFile);
            List lines = IOUtils.readLines(fin);
            fin.close();
            pid = StringUtils.join(lines.toArray());
        }
        return pid;
    } 

Comments

  1. I am surprised that your code review team is allowing you to put in such a jsp. Usually a fork/exec system command run from inside the jvm is not a good idea. Also, if you have some other problem with your java server, this lsof will not return causing more threads to be consumed in your java server waiting for this to finish.

    I think you should use some other process for generating this output.

    -Chris

    ReplyDelete
  2. Chris,

    Thanks for reviewing, I agree that in some situations like when a mount point is totally toast lsof might not return, in that case anyways there would be other tomcat threads that would be stuck in filer I/O and that tomcat would anyways need a bounce in maintenance window to come to a sane state. This JSP will be called in some rare situations and in most of the situations lsof should return and in case the first execution of jsp is stuck, I wont call another one to avoid tomcat threads being gobbled up.

    ReplyDelete

Post a Comment

Popular posts from this blog

RabbitMQ java clients for beginners

Here is a sample of a consumer and producer example for RabbitMQ. The steps are
Download ErlangDownload Rabbit MQ ServerDownload Rabbit MQ Java client jarsCompile and run the below two class and you are done.
This sample create a Durable Exchange, Queue and a Message. You will have to start the consumer first before you start the for the first time.

For more information on AMQP, Exchanges, Queues, read this excellent tutorial
http://blogs.digitar.com/jjww/2009/01/rabbits-and-warrens/

+++++++++++++++++RabbitMQProducer.java+++++++++++++++++++++++++++
import com.rabbitmq.client.Connection; import com.rabbitmq.client.Channel; import com.rabbitmq.client.*; public class RabbitMQProducer { public static void main(String []args) throws Exception { ConnectionFactory factory = new ConnectionFactory(); factory.setUsername("guest"); factory.setPassword("guest"); factory.setVirtualHost("/"); factory.setHost("127.0.0.1"); factory.setPort(5672); Conne…

Logging to Graphite monitoring tool from java

We use Graphite as a tool for monitoring some stats and watch trends. A requirement is to monitor impact of new releases as build is deployed to app nodes to see if things like
1) Has the memcache usage increased.
2) Has the no of Java exceptions went up.
3) Is the app using more tomcat threads.
Here is a screenshot

We changed the installer to log a deploy event when a new build is deployed. I wrote a simple spring bean to log graphite events using java. Logging to graphite is easy, all you need to do is open a socket and send lines of events.
import org.slf4j.Logger;import org.slf4j.LoggerFactory; import java.io.OutputStreamWriter; import java.io.Writer; import java.net.Socket; import java.util.HashMap; import java.util.Map; public class GraphiteLogger { private static final Logger logger = LoggerFactory.getLogger(GraphiteLogger.class); private String graphiteHost; private int graphitePort; public String getGraphiteHost() { return graphiteHost; } public void setGraphite…

Jersey posting multipart data

This took me sometime to figure out mostly it was because I was only including jersey-multipart-1.6.jar but I was not including mimepull-1.3.jar.

So the intent is to upload a file using REST api and we need pass meta attributes in addition to uploading the file. Also the intent is to stream the file instead of first storing it on the local disk. Here is some sample code.
@Path("/upload-service") public class UploadService { @Context protected HttpServletResponse response; @Context protected HttpServletRequest request; @POST @Consumes(MediaType.MULTIPART_FORM_DATA) @Produces(MediaType.APPLICATION_JSON) public String uploadFile(@PathParam("fileName") final String fileName, @FormDataParam("workgroupId") String workgroupId, @FormDataParam("userId") final int userId, @FormDataParam("content") final InputStream content) throws JSONException { //.......Upload the file to S3 or netapp or any storage service } }
Now to tes…