Skip to main content

Java and lsof

Update: I found that using Runtime.exec was a bad idea because if you have a 2GB VM footprint then the forked process would require 2G free memory in order to run the lsof command.  We had earlier writte a simple python http rpc server that would allow us to execute native commands(like creating a hardlink or running gunzip) from Java and I changed this code to delagate to RPC call few days back.
So the new code looks like



 public void writeTopCommandOutput(Writer writer) throws IOException {
  String rpcRes = Util.doCommandRpc(rpcUrl, "", ListUtil.create("top", "-n", "2", "-b", "-d", "0.2"));
  writer.write(rpcRes);
 }

 public void writeLsofOutput(Writer writer) throws IOException {
  String pid = getJvmProcessid();
  if (pid != null) {
   pid = pid.trim();
   String rpcRes = Util.doCommandRpc(rpcUrl, "", ListUtil.create("lsof", "-p", pid));
   writer.write(rpcRes);
  }
 }


 --------------------------------------
I was chasing a customer issue and some threads in threaddump showed that they are stuck doing filer I/O. Now I needed to chase what file paths these threads are accessing as few days ago this customer had expereinced same issue. So I asked operations to give me lsof output and as we are a distribured team and engineers dont have access to production machines.It always takes time to chase people and to a programmer this means lots of context switches and it derails your thought process.  My goal is to eliminate as many hoops in my debugging path so I wrote a JSP to get me lsof output from java. This will be a jsp accessible through internal ips only, hurray from next release onwards one more reason to avoid Operations team in chasing issues.
Here is the method I added in jsp


    public void writeLsofOutput(Writer writer) throws IOException {
        String pid = getJvmProcessid();
        if(pid!=null){
            pid = pid.trim();
            String cmdLsof = "lsof -p " + pid;
            executeCmd(writer, cmdLsof);            
        }
    }

    private void executeCmd(Writer writer, String cmd) throws IOException {
        String output;
        Process child = Runtime.getRuntime().exec(cmd, new String []{});            
        BufferedReader stdInput = new BufferedReader(new InputStreamReader(child.getInputStream()));
        while ((output = stdInput.readLine()) != null) {
            writer.write(output + "\n");
            writer.flush();
        }
        stdInput.close();
    }
    public String getJvmProcessid() throws IOException {
        String pid = null;
        File pidFile = new File(System.getenv("CATALINA_PID"));
        if(pidFile.exists()) {
            FileInputStream fin = new FileInputStream(pidFile);
            List lines = IOUtils.readLines(fin);
            fin.close();
            pid = StringUtils.join(lines.toArray());
        }
        return pid;
    } 

Comments

  1. I am surprised that your code review team is allowing you to put in such a jsp. Usually a fork/exec system command run from inside the jvm is not a good idea. Also, if you have some other problem with your java server, this lsof will not return causing more threads to be consumed in your java server waiting for this to finish.

    I think you should use some other process for generating this output.

    -Chris

    ReplyDelete
  2. Chris,

    Thanks for reviewing, I agree that in some situations like when a mount point is totally toast lsof might not return, in that case anyways there would be other tomcat threads that would be stuck in filer I/O and that tomcat would anyways need a bounce in maintenance window to come to a sane state. This JSP will be called in some rare situations and in most of the situations lsof should return and in case the first execution of jsp is stuck, I wont call another one to avoid tomcat threads being gobbled up.

    ReplyDelete

Post a Comment

Popular posts from this blog

RabbitMQ java clients for beginners

Here is a sample of a consumer and producer example for RabbitMQ. The steps are
Download ErlangDownload Rabbit MQ ServerDownload Rabbit MQ Java client jarsCompile and run the below two class and you are done.
This sample create a Durable Exchange, Queue and a Message. You will have to start the consumer first before you start the for the first time.

For more information on AMQP, Exchanges, Queues, read this excellent tutorial
http://blogs.digitar.com/jjww/2009/01/rabbits-and-warrens/

+++++++++++++++++RabbitMQProducer.java+++++++++++++++++++++++++++
import com.rabbitmq.client.Connection; import com.rabbitmq.client.Channel; import com.rabbitmq.client.*; public class RabbitMQProducer { public static void main(String []args) throws Exception { ConnectionFactory factory = new ConnectionFactory(); factory.setUsername("guest"); factory.setPassword("guest"); factory.setVirtualHost("/"); factory.setHost("127.0.0.1"); factory.setPort(5672); Conne…

What a rocky start to labor day weekend

Woke up by earthquake at 7:00 AM in morning and then couldn't get to sleep. I took a bath, made my tea and started checking emails and saw that after last night deployment three storage node out of 100s of nodes were running into Full GC. What was special about the 3 nodes was that each one was in a different Data centre but it was named same app02.  This got me curious I asked the node to be taken out of rotation and take a heap dump.  Yesterday night a new release has happened and I had upgraded spymemcached library version as new relic now natively supports instrumentation on it so it was a suspect. And the hunch was a bullseye, the heap dump clearly showed it taking 1.3G and full GCs were taking 6 sec but not claiming anything.



I have a quartz job in each jvm that takes a thread dump every 5 minutes and saves last 300 of them, checking few of them quickly showed a common thread among all 3 data centres. It seems there was a long running job that was trying to replicate pending…

Email slavery

It seems I have become an EmailSlave. The first half of the day is spent in just answering to emails. There are so many emails where I am copied but I need not be. There are many emails  where its a 1-2 page email and somewhere down someone says @KP please answer this.  So it seems daily my work schedule is:
Signin to newrelic and check anomalies for 15 min. Check emails related production exception report and yes there are a ton of these report daily. Need a better tool here as this model is not scalable. I need to reduce the incoming data at me to only see relevant data like what newrelic does. May be I need to create a webapp out of these emails.Check emails for next few minutes before team callsDo team callsThen again back to checking emails until a I have taken a best shot at answering everyone waiting for my reply.Attend team meetings on Tue/Thu
Being an architect and coder at heart I don't feel satisfied at end of the day if there is nothing tangible getting done at the end.…