Skip to main content

Carrying over Log4j context in threadpool

We use MDC feature of slf4j/log4j to automatically log the details about user/client that is making the request so we can trace the things happening in the thread. 


    public static void setRequestId(String requestId) {
        if (requestId != null) {
            MDC.put("MDC_REQUEST_ID", requestId);
        } else {
            MDC.put("MDC_REQUEST_ID", "");
        }
    }

    public static void setUserInContext(long userId) {
        MDC.put("MDC_USER_ID", String.valueOf(userId));
    }

and the log4j appender users

    <appender name="RFA_ROOT" class="org.apache.log4j.rolling.RollingFileAppender">
        <rollingPolicy class="org.apache.log4j.rolling.TimeBasedRollingPolicy">
          <param name="FileNamePattern" value="${catalina.base}/logs/kp.log.%d{yyyy-MM-dd-HH}"/>
          <param name="ActiveFileName" value="${catalina.base}/logs/kp.log"/>
        </rollingPolicy>
        <layout class="org.apache.log4j.PatternLayout">
            <param name="ConversionPattern" value="%p %d{ISO8601} %t D-%X{MDC_DOMAIN} U-%X{MDC_USER_ID} S-%X{MDC_SYNC_CID} R-%X{MDC_REQUEST_ID} %c - %m%n"/>
        </layout>
    </appender>

This will automatically print User and request Id but when you want to get the user requests funnel through some threadpool to avoid thundering herd problem then the log4j context is not carried over and this breaks traceability. To solve this problem the easy solution is to just create your own Callable and use that in thread pool.

public abstract class MyCallable implements Callable {
    private Map contextMap = AppLogger.getCopyOfContextMap();
   
    @Override
    public T call() throws Exception {
        MDC.setContextMap(contextMap);
        try {
            return internalCall();
        } finally {
            MDC.clear();
        }
    }

    protected abstract T internalCall() throws Exception;

}


        MyCallable task = new MyCallable() {
            @Override
            public String internalCall() throws Exception {
...

           }
        };

and use
SpringBeanLocator.getRestRequestHelper().getRestRequestExecutors().submit(task);

This way your context would be carried over to background threads.

Comments

Popular posts from this blog

RabbitMQ java clients for beginners

Here is a sample of a consumer and producer example for RabbitMQ. The steps are
Download ErlangDownload Rabbit MQ ServerDownload Rabbit MQ Java client jarsCompile and run the below two class and you are done.
This sample create a Durable Exchange, Queue and a Message. You will have to start the consumer first before you start the for the first time.

For more information on AMQP, Exchanges, Queues, read this excellent tutorial
http://blogs.digitar.com/jjww/2009/01/rabbits-and-warrens/

+++++++++++++++++RabbitMQProducer.java+++++++++++++++++++++++++++
import com.rabbitmq.client.Connection; import com.rabbitmq.client.Channel; import com.rabbitmq.client.*; public class RabbitMQProducer { public static void main(String []args) throws Exception { ConnectionFactory factory = new ConnectionFactory(); factory.setUsername("guest"); factory.setPassword("guest"); factory.setVirtualHost("/"); factory.setHost("127.0.0.1"); factory.setPort(5672); Conne…

Logging to Graphite monitoring tool from java

We use Graphite as a tool for monitoring some stats and watch trends. A requirement is to monitor impact of new releases as build is deployed to app nodes to see if things like
1) Has the memcache usage increased.
2) Has the no of Java exceptions went up.
3) Is the app using more tomcat threads.
Here is a screenshot

We changed the installer to log a deploy event when a new build is deployed. I wrote a simple spring bean to log graphite events using java. Logging to graphite is easy, all you need to do is open a socket and send lines of events.
import org.slf4j.Logger;import org.slf4j.LoggerFactory; import java.io.OutputStreamWriter; import java.io.Writer; import java.net.Socket; import java.util.HashMap; import java.util.Map; public class GraphiteLogger { private static final Logger logger = LoggerFactory.getLogger(GraphiteLogger.class); private String graphiteHost; private int graphitePort; public String getGraphiteHost() { return graphiteHost; } public void setGraphite…

What a rocky start to labor day weekend

Woke up by earthquake at 7:00 AM in morning and then couldn't get to sleep. I took a bath, made my tea and started checking emails and saw that after last night deployment three storage node out of 100s of nodes were running into Full GC. What was special about the 3 nodes was that each one was in a different Data centre but it was named same app02.  This got me curious I asked the node to be taken out of rotation and take a heap dump.  Yesterday night a new release has happened and I had upgraded spymemcached library version as new relic now natively supports instrumentation on it so it was a suspect. And the hunch was a bullseye, the heap dump clearly showed it taking 1.3G and full GCs were taking 6 sec but not claiming anything.



I have a quartz job in each jvm that takes a thread dump every 5 minutes and saves last 300 of them, checking few of them quickly showed a common thread among all 3 data centres. It seems there was a long running job that was trying to replicate pending…