Skip to main content

Spring proxyFactoryBean not applying interceptors and circular dependencies

We use AOP a lot but due to legacy reasons we dont use aspectJ yet and we are using Spring ProxyFactoryBean and use interceptors to apply AOP behavior like light weight instrumentation or transactions.

 Lately we ran into two or three issues where on some proxyFactoryBeans the interceptors wont be applied.  My hunch was it was some circular dependency between beans so I added DEBUG on org.springframework.beans in log4j and it spitted tons of logs, I did a grep

  grep "that is not fully initialized yet - a consequence of a circular reference" ~/apache-tomcat-7.0.30/logs/tomcat.log |awk -F "singleton" '{print $2}'|sort|uniq  

 it would print some message like 

bean 'gdriveClient' that is not fully initialized yet - a consequence of a circular reference
 bean 'gdriveRestServiceHelper' that is not fully initialized yet - a consequence of a circular reference
 bean 'filerServiceRequestHandlerFactory' that is not fully initialized yet - a consequence of a circular reference
 bean 'objectReplicationManager' that is not fully initialized yet - a consequence of a circular reference
But this was a painful way to  analyse it and I wanted to future proof the code so that developers in future cant introduce a circular dependency.

Today I found that instead of loading context like 
ClassPathXmlApplicationContext context = new ClassPathXmlApplicationContext("/applicationContext.xml");
You  can do something like

ClassPathXmlApplicationContext context = new ClassPathXmlApplicationContext();
context.setAllowCircularReferences(false); 
context.setConfigLocation("/applicationContext.xml");
context.refresh();

and this would fail on first circular reference encountered.  This prints in log entire hierarchy of bean it was trying to load so its very easy to chain the beans to find circular reference. I haven’t committed the code yet but the idea is to fix all existing circular dependencies and then enable this code.


Comments

Post a Comment

Popular posts from this blog

RabbitMQ java clients for beginners

Here is a sample of a consumer and producer example for RabbitMQ. The steps are Download Erlang Download Rabbit MQ Server Download Rabbit MQ Java client jars Compile and run the below two class and you are done. This sample create a Durable Exchange, Queue and a Message. You will have to start the consumer first before you start the for the first time. For more information on AMQP, Exchanges, Queues, read this excellent tutorial http://blogs.digitar.com/jjww/2009/01/rabbits-and-warrens/ +++++++++++++++++RabbitMQProducer.java+++++++++++++++++++++++++++ import com.rabbitmq.client.Connection; import com.rabbitmq.client.Channel; import com.rabbitmq.client.*; public class RabbitMQProducer { public static void main(String []args) throws Exception { ConnectionFactory factory = new ConnectionFactory(); factory.setUsername("guest"); factory.setPassword("guest"); factory.setVirtualHost("/"); factory.setHost("127.0.0.1"); factory.se...
23 comments
Read more

Spring 3.2 quartz 2.1 Jobs added with no trigger must be durable.

I am trying to enable HA on nodes and in that process I found that in a two test node setup a job that has a frequency of 10 sec was running into deadlock. So I tried upgrading from Quartz 1.8 to 2.1 by following the migration guide but I ran into an exception that says "Jobs added with no trigger must be durable.". After looking into spring and Quartz code I figured out that now Quartz is more strict and earlier the scheduler.addJob had a replace parameter which if passed to true would skip the durable check, in latest quartz this is fixed but spring hasnt caught up to this. So what do you do, well I jsut inherited the factory and set durability to true and use that public class DurableJobDetailFactoryBean extends JobDetailFactoryBean {     public DurableJobDetailFactoryBean() {         setDurability(true);     } } and used this instead of JobDetailFactoryBean in the spring bean definition     <bean i...
7 comments
Read more

Killing a particular Tomcat thread

Update: This JSP does not work on a thread that is inside some native code.  On many occasions I had a thread stuck in JNI code and it wont work. Also in some cases thread.stop can cause jvm to hang. According to javadocs " This method is inherently unsafe. Stopping a thread with Thread.stop causes it to unlock all of the monitors that it has locked". I have used it only in some rare occasions where I wanted to avoid a system shutdown and in some cases we ended up doing system shutdown as jvm was hung so I had a 70-80% success with it.   -------------------------------------------------------------------------------------------------------------------------- We had an interesting requirement. A tomcat thread that was spawned from an ExecutorService ThreadPool had gone Rogue and was causing lots of disk churning issues. We cant bring down the production server as that would involve downtime. Killing this thread was harmless but how to kill i...
6 comments
Read more