Skip to main content

Premature optimization

I have been assigned the task to increase the the performance of the application in my last 2 companies and from my past experience I believe in 80-20 code execution rule, i.e. in production most of the time its the 20% of the code that is being executed and the rest 80% is used rarely. Therefore before you embark on increasing the performance of the website
  1. You should know your customers
  2. You should know their usage patterns
  3. You should first collect statistics about what are the features that customers are using heavily
Don't try to guess which features are used, do a quantitative analysis and focus on only those features that are used heavily. Apache/Tomcat access logs can be your buddies in reaching the goal, take daily logs from last 2-3 months put them in mysql or any DB using some simple python/perl script and create some excel graphs and do a trend analysis. For example in the below graph of webdav usage, I would rather focus on optimizing the PROPFINDs first then other operations.

Writing simple code is hard, following KISS (http://en.wikipedia.org/wiki/KISS_principle) is tough, whenever you try to increase performance of a feature you compromise simplicity and make the code a bit more complex then it was before. Therefore I don't believe in premature optimization, Donald Knuth had said "We should forget about small efficiencies, say about 97% of the time: premature optimization is the root of all evil".

Every programmer should follow some basic programming guidelines for performance when writing code but he shouldn't be too obsessive about performance when writing code, I have seen people writing Java code like C. They would not use Java's Date datatype or ArrayList and will use long to store dates and arrays instead of arraylist everywhere. Now tell me this if you are developing some Admin screens,user profile screens for a website or you are developing some internal application to be used by a handful of people making 100-200 request in an hour, why would you spend so much time making the code worse and complex by optimizing it prematurely. Analyze your apache logs insanely and focus on features that are used by customers heavily. Take the first 10 culprits optimize them and then repeat the process till you feel no more juice can be squeezed from the lemon.To optimize the top culprits if you have to compromise simplicity then its ok but don't make the job for the guy who is going to maintain the code after you leave hard by prematurely optimizing the whole code base.

Ofcourse if you are designing a new feature in an application and you foresee that it's going to be used heavily then  keep scalability and performance in mind when architecting the application but keep the code simple and before releasing it do some load testing using Jmeter or Load Runner and profile the code using some tool like JProfiler and optimize only the hotspots (code that is being executed 80% of the time ;) ).

Comments

Popular posts from this blog

RabbitMQ java clients for beginners

Here is a sample of a consumer and producer example for RabbitMQ. The steps are
Download ErlangDownload Rabbit MQ ServerDownload Rabbit MQ Java client jarsCompile and run the below two class and you are done.
This sample create a Durable Exchange, Queue and a Message. You will have to start the consumer first before you start the for the first time.

For more information on AMQP, Exchanges, Queues, read this excellent tutorial
http://blogs.digitar.com/jjww/2009/01/rabbits-and-warrens/

+++++++++++++++++RabbitMQProducer.java+++++++++++++++++++++++++++
import com.rabbitmq.client.Connection; import com.rabbitmq.client.Channel; import com.rabbitmq.client.*; public class RabbitMQProducer { public static void main(String []args) throws Exception { ConnectionFactory factory = new ConnectionFactory(); factory.setUsername("guest"); factory.setPassword("guest"); factory.setVirtualHost("/"); factory.setHost("127.0.0.1"); factory.setPort(5672); Conne…

Logging to Graphite monitoring tool from java

We use Graphite as a tool for monitoring some stats and watch trends. A requirement is to monitor impact of new releases as build is deployed to app nodes to see if things like
1) Has the memcache usage increased.
2) Has the no of Java exceptions went up.
3) Is the app using more tomcat threads.
Here is a screenshot

We changed the installer to log a deploy event when a new build is deployed. I wrote a simple spring bean to log graphite events using java. Logging to graphite is easy, all you need to do is open a socket and send lines of events.
import org.slf4j.Logger;import org.slf4j.LoggerFactory; import java.io.OutputStreamWriter; import java.io.Writer; import java.net.Socket; import java.util.HashMap; import java.util.Map; public class GraphiteLogger { private static final Logger logger = LoggerFactory.getLogger(GraphiteLogger.class); private String graphiteHost; private int graphitePort; public String getGraphiteHost() { return graphiteHost; } public void setGraphite…

What a rocky start to labor day weekend

Woke up by earthquake at 7:00 AM in morning and then couldn't get to sleep. I took a bath, made my tea and started checking emails and saw that after last night deployment three storage node out of 100s of nodes were running into Full GC. What was special about the 3 nodes was that each one was in a different Data centre but it was named same app02.  This got me curious I asked the node to be taken out of rotation and take a heap dump.  Yesterday night a new release has happened and I had upgraded spymemcached library version as new relic now natively supports instrumentation on it so it was a suspect. And the hunch was a bullseye, the heap dump clearly showed it taking 1.3G and full GCs were taking 6 sec but not claiming anything.



I have a quartz job in each jvm that takes a thread dump every 5 minutes and saves last 300 of them, checking few of them quickly showed a common thread among all 3 data centres. It seems there was a long running job that was trying to replicate pending…