Skip to main content

Band-Aid programming

I saw a code sample last Saturday for someone where there was a method with 9 TODOs and I saw some code that was doing


                xxxDao.setLastSectionNum(custId, lastSectionNum);
                xxxDao.setLastChangeNum(custId, lastChangeNum);
                xxxDao.setLastModified(custId, now, xxxContext);
                if (subject == null) {
                        xxxDao.updateSubject(custId, subject);
                }

My blood was boiling after seeing this. This is what is called as band aid programming. I found out that programmer has added first line 2 years ago and then one more requirement came in so he added one more dao method and in 2 years we get 4 methods. WTH couldnt he refactor the code to just do 1 update query or use some ORM with POJO. 

But to me he is typical band-aid programmer because I saw 9 TODOs in one 100 lines method. What that tells me is that he is just fixing bare minimum things and is having a tunnel vision.

Comments

Post a Comment

Popular posts from this blog

RabbitMQ java clients for beginners

Here is a sample of a consumer and producer example for RabbitMQ. The steps are
Download ErlangDownload Rabbit MQ ServerDownload Rabbit MQ Java client jarsCompile and run the below two class and you are done.
This sample create a Durable Exchange, Queue and a Message. You will have to start the consumer first before you start the for the first time.

For more information on AMQP, Exchanges, Queues, read this excellent tutorial
http://blogs.digitar.com/jjww/2009/01/rabbits-and-warrens/

+++++++++++++++++RabbitMQProducer.java+++++++++++++++++++++++++++
import com.rabbitmq.client.Connection; import com.rabbitmq.client.Channel; import com.rabbitmq.client.*; public class RabbitMQProducer { public static void main(String []args) throws Exception { ConnectionFactory factory = new ConnectionFactory(); factory.setUsername("guest"); factory.setPassword("guest"); factory.setVirtualHost("/"); factory.setHost("127.0.0.1"); factory.setPort(5672); Conne…
23 comments
Read more

Spring query timeout or transaction timeout

If you are using spring to manage transactions then you can specify default transaction timeout using

    <bean id="transactionManager"
        class="org.springframework.jdbc.datasource.DataSourceTransactionManager">
        <property name="dataSource" ref="dataSource" />
        <property name="defaultTimeout" value="30" /> <!--30 sec--->             
    </bean>

or you can override the timeout in the annotation

    @Transactional(readOnly = false, timeout=30)


or if you are doing it programatic transactions then you can do


DataSourceTransactionManager transactionManager = new DataSourceTransactionManager(dataSource);
transactionManager.setDefaultTimeout(30);

 or you can override the timeout for one particular transaction

TransactionTemplate transactionTemplate = new TransactionTemplate();
transactionTemplate.setTimeout(30);
Post a Comment
Read more

Python adding pid file

I have a thumbnail generator that launches multiple processes and the correct way to shut it down is to send kill -HUP to the parent process. To automate I had to write a pid file from python, it was a piece of cake
def writePidFile(): pid = str(os.getpid()) f = open('thumbnail_rabbit_consumer.pid', 'w') f.write(pid) f.close()
Post a Comment
Read more